Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Deactivate detour flow #2805

Merged
merged 1 commit into from
Sep 25, 2024
Merged

feat: Deactivate detour flow #2805

merged 1 commit into from
Sep 25, 2024

Conversation

joshlarson
Copy link
Contributor

@github-actions GitHub Actions
Copy link

Coverage of commit 2c95114

Summary coverage rate:
  lines......: 92.5% (3310 of 3580 lines)
  functions..: 71.4% (1366 of 1912 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit 7a20ef9

Summary coverage rate:
  lines......: 92.5% (3310 of 3580 lines)
  functions..: 71.4% (1366 of 1912 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/detours/detours.ex                                    |86.8%     38|76.5%    17|    -      0

Download coverage report

@joshlarson joshlarson marked this pull request as ready for review September 24, 2024 13:18
@joshlarson joshlarson requested a review from a team as a code owner September 24, 2024 13:18
Base automatically changed from jdl/feat/activate-detour-modal to main September 24, 2024 17:21
@joshlarson joshlarson force-pushed the jdl/feat/deactivate-detour-modal branch from 7a20ef9 to fc4f7f8 Compare September 24, 2024 18:56
@joshlarson joshlarson force-pushed the jdl/feat/deactivate-detour-modal branch from fc4f7f8 to c39f4dd Compare September 24, 2024 18:57
@github-actions GitHub Actions
Copy link

Coverage of commit c39f4dd

Summary coverage rate:
  lines......: 92.5% (3310 of 3580 lines)
  functions..: 71.4% (1366 of 1912 functions)
  branches...: no data found

Files changed coverage rate:
                                                                  |Lines       |Functions  |Branches    
  Filename                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================
  lib/skate/detours/detours.ex                                    |86.8%     38|76.5%    17|    -      0

Download coverage report

@joshlarson joshlarson mentioned this pull request Sep 24, 2024
Merged
@joshlarson joshlarson enabled auto-merge (squash) September 24, 2024 20:01
@hannahpurcell hannahpurcell self-assigned this Sep 25, 2024
hannahpurcell
hannahpurcell approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great! Looks like hi-fi is captured in a new task that we should do sooner than later, given route pill was omitted here. Luckily, this PR followed the format of the activate flow, so pretty easy to review

@joshlarson joshlarson merged commit 27de03c into main Sep 25, 2024
9 checks passed
@joshlarson joshlarson deleted the jdl/feat/deactivate-detour-modal branch September 25, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahpurcell hannahpurcell hannahpurcell approved these changes

Assignees

@hannahpurcell hannahpurcell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshlarson @hannahpurcell