feat: add detour deactivated notifications #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
force-pushed
the
kf/asn/dn/distributed-notifications
branch
4 times, most recently
from
9a00bcb
to
982cd80
Compare
firestack
force-pushed
the
kf/asn/dn/deactivate-detour
branch
from
4e8995f
to
6c2d467
Compare
firestack
force-pushed
the
kf/asn/dn/distributed-notifications
branch
2 times, most recently
from
09fbd53
to
de5f81d
Compare
firestack
force-pushed
the
kf/asn/dn/deactivate-detour
branch
from
6c2d467
to
ea4cb63
Compare
firestack
force-pushed
the
kf/asn/dn/distributed-notifications
branch
from
de5f81d
to
5021524
Compare
firestack
force-pushed
the
kf/asn/dn/deactivate-detour
branch
2 times, most recently
from
dd9f99e
to
72f6e4a
Compare
firestack
force-pushed
the
kf/asn/dn/distributed-notifications
branch
from
78eb980
to
58a736e
Compare
firestack
force-pushed
the
kf/asn/dn/deactivate-detour
branch
2 times, most recently
from
7b50d43
to
a731ae0
Compare
firestack
force-pushed
the
kf/asn/dn/distributed-notifications
branch
from
58a736e
to
9427227
Compare
firestack
force-pushed
the
kf/asn/dn/deactivate-detour
branch
from
a731ae0
to
415ace8
Compare
firestack
force-pushed
the
kf/asn/dn/distributed-notifications
branch
from
9427227
to
aeeb583
Compare
firestack
force-pushed
the
kf/asn/dn/deactivate-detour
branch
from
415ace8
to
734c38a
Compare
firestack
force-pushed
the
kf/asn/dn/distributed-notifications
branch
2 times, most recently
from
38a42a4
to
1264374
Compare
firestack
force-pushed
the
kf/asn/dn/deactivate-detour
branch
2 times, most recently
from
90d906c
to
57f9cc2
Compare
firestack
force-pushed
the
kf/asn/dn/distributed-notifications
branch
from
1264374
to
ed0102b
Compare
firestack
changed the base branch from
kf/asn/dn/distributed-notifications
to
main
firestack
force-pushed
the
kf/asn/dn/deactivate-detour
branch
from
57f9cc2
to
b927615
Compare
hannahpurcell
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Ticket: https://app.asana.com/0/1203014709808707/1208409921049870/f
This implements deactivated notifications through the entire stack, from the notification internals, all the way to the deactivated card.
TODO:
eslintnot properly detecting that all possible branches of theswitchare handled. Maybe I did something wrong here and I'd love that pointed out, but if I add an explicitbreakto makeeslinthappy, typescript then complains that the break is "unreachable" and "unnecessary". Still looking into this.Depends On:
feat(ex/notifications/notification_server): send notification to all connected Skate instances #2831