Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: split up build and deploy steps #2838

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: split up build and deploy steps #2838

merged 1 commit into from
Oct 8, 2024

Conversation

firestack
Copy link
Member

@firestack firestack commented Oct 4, 2024 •
edited
Loading

When deploying #2831 I was having difficulties with getting the deployment to succeed due to our database issues. It was getting pretty frustrating to have to build the docker container just to attempt a redeploy. I tried a few ways of parallelizing this, but so far this seems like the best option.

I was having trouble getting a deploy to work for testing this, so this also depends on #2841
Depends on:

@firestack firestack changed the base branch from main to kf/fix/tzdata October 7, 2024 17:27
@firestack firestack marked this pull request as ready for review October 7, 2024 18:01
@firestack firestack requested a review from a team as a code owner October 7, 2024 18:01
@firestack firestack mentioned this pull request Oct 7, 2024
Merged
hannahpurcell
hannahpurcell approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and tests well in your dev deployments. One question I don't understand, but otherwise, this seems reasonable.

.github/workflows/deploy-base.yml Show resolved Hide resolved
Base automatically changed from kf/fix/tzdata to main October 7, 2024 21:00
@firestack firestack enabled auto-merge (squash) October 7, 2024 23:04
@firestack firestack merged commit 353d644 into main Oct 8, 2024
16 checks passed
@firestack firestack deleted the kf/fix/split-steps branch October 8, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahpurcell hannahpurcell hannahpurcell approved these changes

Assignees
No one assigned
Labels
deploy-to-dev-green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firestack @hannahpurcell