Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Active detour in mobile drawer #2844

Merged
merged 27 commits into from
Oct 10, 2024
Merged

feat: Active detour in mobile drawer #2844

merged 27 commits into from
Oct 10, 2024

Commits on Oct 7, 2024

  1. feat: Simple drawer component

    @hannahpurcell
    hannahpurcell committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    4daf63a View commit details
    Browse the repository at this point in the history

  2. feat: Active detour in drawer on mobile

    @hannahpurcell
    hannahpurcell committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    7e603ff View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Merge branch 'main' into hp/simple-drawer

    @hannahpurcell
    hannahpurcell committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    1aba57f View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Merge branch 'main' into hp/simple-drawer

    @hannahpurcell
    hannahpurcell committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    b5a1d95 View commit details
    Browse the repository at this point in the history

  2. tweak: move isMobile to separate utility file along with DeviceType

    @hannahpurcell
    hannahpurcell committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    efac010 View commit details
    Browse the repository at this point in the history

  3. tweak: fix grid header for detourModal

    @hannahpurcell
    hannahpurcell committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    3fe4738 View commit details
    Browse the repository at this point in the history

  4. test: fix snapshot with updated classname

    @hannahpurcell
    hannahpurcell committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e9c30b1 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'hp/simple-drawer' into hp/drawer-with-active-detour

    @hannahpurcell
    hannahpurcell committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    3754d9d View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. tests: ensure detour uses drawer on mobile

    @hannahpurcell
    hannahpurcell committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e18a826 View commit details
    Browse the repository at this point in the history

  2. code review: Use more precise grid area name 

    Co-authored-by: Kayla Firestack <firestack@users.noreply.github.com>
    @hannahpurcell @firestack
    hannahpurcell and firestack authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b388570 View commit details
    Browse the repository at this point in the history

  3. code review: use grid-area instead of both grid-row and -column 

    Co-authored-by: Kayla Firestack <firestack@users.noreply.github.com>
    @hannahpurcell @firestack
    hannahpurcell and firestack authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    43a2b8e View commit details
    Browse the repository at this point in the history

  4. tweak: prettier

    @hannahpurcell
    hannahpurcell committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    c9c0c48 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'hp/drawer-with-active-detour' of https://github.com/mbt… 

    …a/skate into hp/drawer-with-active-detour
    @hannahpurcell
    hannahpurcell committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4fd3f40 View commit details
    Browse the repository at this point in the history

  6. tweak: prettier

    @hannahpurcell
    hannahpurcell committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    896517c View commit details
    Browse the repository at this point in the history

  7. refactor(ts/drawer): split drawer into two components

    @firestack
    firestack committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    86aecd6 View commit details
    Browse the repository at this point in the history

  8. tweak: remove default export

    @hannahpurcell
    hannahpurcell committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d5e92c0 View commit details
    Browse the repository at this point in the history

  9. tweak: export DrawerWithState, not Drawer

    @hannahpurcell
    hannahpurcell authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6bb2d1c View commit details
    Browse the repository at this point in the history

  10. tweak: prettier

    @hannahpurcell
    hannahpurcell committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6d602a3 View commit details
    Browse the repository at this point in the history

  11. tweak: remove unneeded prop 

    Co-authored-by: Kayla Firestack <firestack@users.noreply.github.com>
    @hannahpurcell @firestack
    hannahpurcell and firestack authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d0a4b7a View commit details
    Browse the repository at this point in the history

  12. Merge branch 'hp/simple-drawer' into hp/drawer-with-active-detour

    @hannahpurcell
    hannahpurcell committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7e94d7e View commit details
    Browse the repository at this point in the history

  13. tweak: integration polish after merging updates to DrawerWithState

    @hannahpurcell
    hannahpurcell committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    27be4ba View commit details
    Browse the repository at this point in the history

  14. tweak: start with drawer open

    @hannahpurcell
    hannahpurcell committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d844c6d View commit details
    Browse the repository at this point in the history

  15. tweak: just check button change as opposed to making a whole new snap… 

    …shot
    @hannahpurcell
    hannahpurcell committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    312054d View commit details
    Browse the repository at this point in the history

  16. Update assets/src/components/detours/diversionPage.tsx 

    Co-authored-by: Kayla Firestack <firestack@users.noreply.github.com>
    @hannahpurcell @firestack
    hannahpurcell and firestack authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    96f2b42 View commit details
    Browse the repository at this point in the history

  17. tweak: fix drawerwithstate ref

    @hannahpurcell
    hannahpurcell committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b8b1d4b View commit details
    Browse the repository at this point in the history

  18. tweak: again! prettier!

    @hannahpurcell
    hannahpurcell committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f10732f View commit details
    Browse the repository at this point in the history

  19. Merge branch 'main' into hp/drawer-with-active-detour

    @hannahpurcell
    hannahpurcell authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1d304b4 View commit details
    Browse the repository at this point in the history