feat(ts/components/vehicleMarker): use ReactMarker for VehicleMarker Icon and Label
#2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
force-pushed
the
kf/refactor/react-vehicle-icon
branch
2 times, most recently
from
1a93e56
to
22c9c30
Compare
hannahpurcell
approved these changes
Oct 11, 2024
|
Approval given, but kinda want to review the follow-up PR before merging if that's ok? |
firestack
changed the title
ReactMarker for VehickeMarker Icon and LabelReactMarker for VehicleMarker Icon and Label
firestack
force-pushed
the
kf/refactor/react-vehicle-icon
branch
from
22c9c30
to
e0b8c90
Compare
`VehicleIcon` uses the `ref` to trigger `Leaflet` functions for popup control
…l into ReactMarker
firestack
force-pushed
the
kf/refactor/react-vehicle-icon
branch
from
e0b8c90
to
a731a65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note: PR Reviewable by commits)
This is the refactor of converting the Vehicle Markers to use
ReactMarkerwhich has many benefits, but a large one being that when a vehicle updates, the entire element is not recreated and replaced (which is likely better for both performance, but also for Devtools in browsers)We could probably combine the label and vehicle icon, but that's out of scope for this PR.
The snapshot changes are not required, but to do so requires creating a custom
DivIcon. They have no effect on the final rendering in browser from the tests I've done. If we do want to avoid this (and I do!) see #2848