fix(ex/Realtime.Server): use broadcast_local instead of broadcast
#2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
force-pushed
the
kf/fix/distributed-data-issue
branch
from
fe2e3f0
to
44d479e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we added distributed Elixir via
DNSClusterin #2831, we started getting flickering data in our realtime sources. This was because we used aPhoenix.PubSubwith the same name on both instances. Once instances were talking to eachother, thosePubSub's started getting messages from other instances but the messages referenced non-existent information, which caused them to sendnullor empty[]information to clients when they received those messages.Switching to
broadcast_localfor ourRealtime.Server.broadcast/2returns the code to it's previous assumptions where a message is only broadcasted to subscribers on the same node, which stopped instances from stepping on eachother.