Stub XR_META_body_tracking_calibration #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… checking for presence before trying to bind functions resulting in application crash
krazysh01
temporarily deployed
to
build-and-sign
GitHub Actions
Inactive
Owner
|
Perfect, thanks you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetaXR SDK attempts to bind the functions of XR_META_body_tracking_calibration if it sees that XR_META_body_tracking_full_body is present, it does not check whether the runtime supports calibration via XR_TYPE_SYSTEM_PROPERTIES_BODY_TRACKING_CALIBRATION_META which will crash applications where the SDK is in use.
Solution: Stub the methods allowing binding but return XR_ERROR_FEATURE_UNSUPPORTED, hopefully devs will follow better practices and not use the extension methods when it's explicitly marked as unsupported.