Adds leaderboard support to PlaceholderAPI #5229
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds placeholders to display mcMMO leaderboard information through PlaceholderAPI. - `%mcmmo_mctop_<skill>:<position>%` - `%mcmmo_mctop_overall:<position>%` - `%mcmmo_mctop_name_<skill>:<position>%` - `%mcmmo_mctop_name_overall:<position>%` - `%mcmmo_checklevel_<skill>:<level>%` - Added a new explanatory file `PLACEHOLDERS.md` detailing all the placeholders that can be used.
nossr50
requested changes
Nov 30, 2025
Member
nossr50
left a comment
nossr50
left a comment
There was a problem hiding this comment.
Looks like some stuff was included by accident that should be removed.
src/main/java/com/gmail/nossr50/placeholders/McTopPositionPlaceholder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
This PR adds leaderboard support to PlaceholderAPI, enabling server administrators to display mcMMO ranking information through placeholders in menus, scoreboards, and other UI elements.
- Implements five new placeholder types for leaderboard queries and level checks
- Adds comprehensive documentation file
PLACEHOLDERS.mdwith usage examples - Updates visibility of
init()method from protected to private
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/java/com/gmail/nossr50/placeholders/PapiExpansion.java |
Adds getLeaderboard() helper method, registers new placeholder types, and changes init() visibility to private |
src/main/java/com/gmail/nossr50/placeholders/OverallRankPlaceholder.java |
New placeholder for displaying player's overall power level rank |
src/main/java/com/gmail/nossr50/placeholders/McTopPositionPlaceholder.java |
New placeholder for retrieving player name or level at specific leaderboard positions |
src/main/java/com/gmail/nossr50/placeholders/CheckLevelPlaceholder.java |
New placeholder for checking if player meets minimum skill level requirements |
src/main/java/com/gmail/nossr50/listeners/BlockListener.java |
Unrelated change: Modifies Fortune enchantment handling for block drops - should be in separate PR |
PLACEHOLDERS.md |
New documentation file detailing all available placeholders with examples and usage patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/com/gmail/nossr50/placeholders/McTopPositionPlaceholder.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gmail/nossr50/placeholders/PapiExpansion.java
Outdated
Show resolved
Hide resolved
Member
|
- Simplifies mctop placeholders - Refactors mctop placeholders to use a single placeholder for both skill level/score and player name. - This removes the need for separate "mctop" and "mctop_name" placeholders, improving usability and reducing code duplication.
- This import is necessary for handling potential exceptions related to invalid skill references within the PlaceholderAPI expansion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds placeholders to display mcMMO leaderboard information through PlaceholderAPI.
%mcmmo_mctop_<skill>:<position>%%mcmmo_mctop_overall:<position>%%mcmmo_mctop_name_<skill>:<position>%%mcmmo_mctop_name_overall:<position>%%mcmmo_checklevel_<skill>:<level>%Added a new explanatory file
PLACEHOLDERS.mddetailing all the placeholders that can be used.