Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard for VC Widgets #1492

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Wizard for VC Widgets #1492

wants to merge 35 commits into from

Conversation

8-Lambda-8
Copy link

I created a copy of the Function Wizard which creates widgets for all channels of the selected Fixtures.

Depending on the channel group, the widgets are configured differently (XY Pad, RGB, Click & Go, Intensity, ...).
image

i wanted this feature for myself, because i often work with different setups and wanted a quick way to setup widgets for groups of fixtures to directly control the channels.

Features i want to add in the Future:

  • options for widget sizes
  • option to split the selected features to frame pages
  • input mapping

@mcallegari
Copy link
Owner

Function wizard creates VC widgets too!
Why not adapting the existing tool?

@coveralls
Copy link

coveralls commented Dec 18, 2023

Coverage Status

coverage: 31.971% (-0.1%) from 32.067%
when pulling 68f638d on 8-Lambda-8:master
into b99c30e on mcallegari:master.

@8-Lambda-8
Copy link
Author

Yes i know, but those widgets are to control the created functions and not to controll the fixtures directly. Because of that i thought it would be better to split them.
But of course i can implement my stuff into the existing one if you like it better like that.
if i do that, should i move the frames of the function widgets into the frame of the "channel widgets" or should i keep them seperate?

@mcallegari
Copy link
Owner

Yes, I prefer to have one tool that does everything.
You can add a "Skip" button in the function creation tab.

if i do that, should i move the frames of the function widgets into the frame of the "channel widgets" or should i keep them seperate?

What are "function widgets"?

@8-Lambda-8
Copy link
Author

8-Lambda-8 commented Dec 18, 2023

Yes, I prefer to have one tool that does everything.

Okay then i will do that

What are "function widgets"?

i meant the widgets that are created by the function wizard (like soloframe with buttons for each color and the cuelist)

should i place those in the same Frame or should i keep them seperate?

For example:

----Fixture Group Frame
|-- XY Pad
|-- RGB Click & go
|-- Color Preset Solo Frame
| |-- Button green
| |-- Button red
| | ...
|-- Color Preset Cue List
|-- Dimmer
| ...

or

----Fixture Group Channel Frame
|-- XY Pad
|-- RGB Click & go
|-- Dimmer
| ...

----Fixture Group Color Frame
|-- Color Preset Solo Frame
| |-- Button green
| |-- Button red
| | ...
|-- Color Preset Cue List

@8-Lambda-8
Copy link
Author

Now everything is in one Wizard

@yestalgia
Copy link
Contributor

Now everything is in one Wizard

Thanks for the contribution and Merry Christmas!

@mcallegari
Copy link
Owner

OK, looks good. Can you please explain what are the numbers displayed beside the widget descriptions?

image

@8-Lambda-8
Copy link
Author

The numbers are the channel numbers of the fixture on which the widgets will act

@yestalgia
Copy link
Contributor

Can we add the wizard shortcut to the VC page as well? I liked the look of that.

This would make sense since it can be used for vc widgets.

@mcallegari
Copy link
Owner

mcallegari commented Dec 27, 2023

Here's another usage case: add a RGB panel (all defaults will do)
Start the wizard and select a few RGB panel rows.
This is the result

image

I would expect one slider for all the heads, but still someone would argue they want to select specific heads.
Also, listing involved channels in this case would be messy, so I would remove it or change it to "(N channels)" rather than the whole list which (at least for me) is irrelevant.

In general, the topic here is: how about multiple head fixtures?

@8-Lambda-8
Copy link
Author

8-Lambda-8 commented Dec 28, 2023

Yes for big RGB Pannels it could be to much widgets, but maybe some users also want this
and yes one Slider to control all Pixels would be good
image
maybe like this?

For multihead fixtures (and also groups of fixtures) maybe it would make sense to have multiple Pages of the Frame with the first page to control ALL and the next pages for each head separate. Maybe with a limit of pages?
image
(Edit: or an option to select between "All", "All+Separate Pages" or "Separate pages")

I think the channel numbers are a sometimes a helpful info. but yes for longer lists it may be better to write something like "(2-6)" instead of "(2, 3, 4, 5, 6)" or the start channel and the count "(5 channels starting with 2)"

should i put the wizard button also on the VC Page like @yestalgia sugested?

@ETE-Design
Copy link

@8-Lambda-8 Is it ready for merge yet?

@8-Lambda-8
Copy link
Author

@ETE-Design no its not ready yet.
like @mcallegari said i have to change the behaviour a bit for RGB Pannels and Multihead fixtures.

@8-Lambda-8
Copy link
Author

8-Lambda-8 commented Apr 21, 2024

Hi, it took a while, but

The Wizard button is back on the VC Page, like @yestalgia wanted:

Can we add the wizard shortcut to the VC page as well? I liked the look of that.

image

for the Multihead problem i solved it with Frame Pages.
with the 3 checkboxes you can select what pages should be created.

if the "All" page is created, the faders of all other pages have the "Monitor selected channels" option enabled

example 8x60 RGB Matrix:
image
image
image

example 2x Chauvet Intimidator Spot duo
image
image

@yestalgia
Copy link
Contributor

This is awesome 😎

@yestalgia
Copy link
Contributor

@8-Lambda-8 Can you please merge master into your branch and push? Then I'll be able to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants