fix: merge Fastify headers with Remix headers instead of overriding them #582
+77
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headers set by Fastify before calling the Remix handler were being overridden by Remix response headers instead of merged. This broke use cases like adding
Linkpreload headers in Fastify middleware.Changes
sendResponseinshared.ts: Collects response headers first, then merges with existing Fastify reply headers instead of replacing themLinkare combined with ", " (exceptSet-Cookiewhich remains separate)Technical notes
The Web Headers API is lossy - it combines multi-value headers with ", " separators. We split on ", " to enable proper merging, which works correctly for
Linkheaders but may incorrectly split headers containing literal commas in their values. This is an acceptable tradeoff given the Headers API provides no alternative.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.