Update rollup to v2.45.x #84
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most notably: - upgrade rollup to latest (2.45.1); - drop support for node versions 4, 6, and 7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83
My project build was failing, so I tracked down the issue to this module. It turned out that, as highlighted by other users, the rollup dependency was too low. I updated it and, as soon as I
npm linked this new branch to my project, everything began to work smoothly again.I've also shifted the range of supported node versions. I dropped the
v4,v6, andv7Travis jobs and added thev10,v12, andv14jobs in their place. However, this shift has forced me to remove a total of 3 gulp plugins. Fortunately, none of them was essential to thecitask.Because of the drastic dependency change, I've decided to mark this version as a major release. Please, let me know if a minor release would be better suited.
Final note: I committed the
package-lock.jsonfile. I believe this file to be important for future installs.