Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ETASU status to determine which links to return in CDS Hooks card. #110

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

plarocque4
Copy link
Contributor

@plarocque4 plarocque4 commented Aug 24, 2023

Describe your changes

Use ETASU status to determine which links to return in CDS Hooks card.

Issue ticket number and Jira link

REMS-421

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

Copy link
Contributor

@zacharyrobin zacharyrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through workflow and it works with no errors.

One thing was the cards only went away after refreshing the page or resubmitting to rems admin. Maybe could add a future task of having a state listener or another way to automatically re-render the component.

@plarocque4
Copy link
Contributor Author

Went through workflow and it works with no errors.

One thing was the cards only went away after refreshing the page or resubmitting to rems admin. Maybe could add a future task of having a state listener or another way to automatically re-render the component.

The hooks and cards are only supposed to be submitted as needed, I'm not sure just resubmitting them repeatedly is the way it's supposed to operate. I'll have to look into that.

@plarocque4 plarocque4 merged commit d67639f into dev Sep 8, 2023
9 checks passed
@plarocque4 plarocque4 deleted the 421-etasu-based-links branch September 8, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants