Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker-healthcheck #156

Merged
merged 14 commits into from
Sep 30, 2024
Merged

Docker-healthcheck #156

merged 14 commits into from
Sep 30, 2024

Conversation

smalho01
Copy link
Collaborator

@smalho01 smalho01 commented Sep 16, 2024

Describe your changes

Successful Run of the Playwright Tests: https://github.com/mcode/rems-setup/actions/runs/10892983168/job/30226995347

Test by running playwright tests locally with system running or in ci/cd by kicking off an action (https://github.com/mcode/rems-setup/actions/workflows/playwright.yml) and specifying corresponding branches

Run on docker-playwright as the branch for rems-setup
Run on branch docker-healthcheck for all other repositories

Issue ticket number and Jira link

https://jira.mitre.org/browse/REMS-749

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

avirgulto
avirgulto previously approved these changes Sep 26, 2024
@smalho01 smalho01 merged commit b041589 into dev Sep 30, 2024
5 of 9 checks passed
@smalho01 smalho01 deleted the docker-healthcheck branch September 30, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants