Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration of Flow Control packets generation #273

Merged
merged 8 commits into from
Jul 29, 2024

Conversation

mdabrowski1990
Copy link
Owner

Description

Add generator of Flow Control parameters that would be used to generate Flow Control packets during message reception.

How Has This Been Tested?

  • unit tests
  • review

Process

I know the process and did my best to follow it

@mdabrowski1990 mdabrowski1990 added the implementation Changes to code label Jul 26, 2024
@mdabrowski1990 mdabrowski1990 self-assigned this Jul 26, 2024
@mdabrowski1990 mdabrowski1990 linked an issue Jul 26, 2024 that may be closed by this pull request
Copy link
Owner Author

@mdabrowski1990 mdabrowski1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make some changes.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (15ab1d5) to head (e11ffb8).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #273   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         2346      2384   +38     
=========================================
+ Hits          2346      2384   +38     
Flag Coverage Δ
integration-tests 87.91% <86.04%> (-0.07%) ⬇️
unit-tests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
uds/can/__init__.py 100.00% <100.00%> (ø)
uds/can/flow_control.py 100.00% <100.00%> (ø)
uds/transport_interface/can_transport_interface.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@mdabrowski1990 mdabrowski1990 linked an issue Jul 26, 2024 that may be closed by this pull request
Copy link
Owner Author

@mdabrowski1990 mdabrowski1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdabrowski1990 mdabrowski1990 merged commit 50e273b into main Jul 29, 2024
58 checks passed
@mdabrowski1990 mdabrowski1990 deleted the flow-control-packets-generation branch July 29, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementation Changes to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage is not updated Configuration of Flow Control packets generation
1 participant