Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract Data Record #294

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Abstract Data Record #294

merged 6 commits into from
Nov 8, 2024

Conversation

mdabrowski1990
Copy link
Owner

Description

Define common API for all Data Records.

How Has This Been Tested?

  • unit tests
  • review

Process

I know the process and did my best to follow it

@mdabrowski1990 mdabrowski1990 added the implementation Changes to code label Nov 4, 2024
@mdabrowski1990 mdabrowski1990 self-assigned this Nov 4, 2024
@mdabrowski1990 mdabrowski1990 linked an issue Nov 4, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b41aa68) to head (f388a29).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #294   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        44    +2     
  Lines         2754      2797   +43     
  Branches       344       345    +1     
=========================================
+ Hits          2754      2797   +43     
Flag Coverage Δ
integration-tests 81.19% <91.48%> (+0.14%) ⬆️
integration-tests-branch 76.11% <91.48%> (+0.22%) ⬆️
unit-tests 100.00% <100.00%> (ø)
unit-tests-branch 100.00% <100.00%> (ø)
Files with missing lines Coverage Δ
uds/__init__.py 100.00% <100.00%> (ø)
uds/can/flow_control.py 100.00% <100.00%> (ø)
uds/database/__init__.py 100.00% <100.00%> (ø)
uds/database/abstract_data_record.py 100.00% <100.00%> (ø)
.../transmission_attributes/transmission_direction.py 100.00% <100.00%> (ø)

Copy link
Owner Author

@mdabrowski1990 mdabrowski1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

uds/database/abstract_data_record.py Show resolved Hide resolved
uds/database/abstract_data_record.py Show resolved Hide resolved
uds/can/flow_control.py Show resolved Hide resolved
@mdabrowski1990 mdabrowski1990 merged commit 4acb193 into main Nov 8, 2024
61 checks passed
@mdabrowski1990 mdabrowski1990 deleted the data-record-api branch November 8, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementation Changes to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Record (signal for message database) API
2 participants