Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for Databases #298

Merged
merged 20 commits into from
Dec 16, 2024
Merged

API for Databases #298

merged 20 commits into from
Dec 16, 2024

Conversation

mdabrowski1990
Copy link
Owner

@mdabrowski1990 mdabrowski1990 commented Nov 20, 2024

Description

  • Abstract Database class defined
  • tiny fix for Abstract Service (distinguishing between request and response message)
  • typing for Data Records

How Has This Been Tested?

  • unit tests

Process

I know the process and did my best to follow it

@mdabrowski1990 mdabrowski1990 added the implementation Changes to code label Nov 20, 2024
@mdabrowski1990 mdabrowski1990 self-assigned this Nov 20, 2024
@mdabrowski1990 mdabrowski1990 linked an issue Nov 20, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8a6b3f8) to head (7b28a08).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #298   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        49    +1     
  Lines         2859      2890   +31     
  Branches       351       356    +5     
=========================================
+ Hits          2859      2890   +31     
Flag Coverage Δ
integration-tests 80.51% <75.00%> (-0.28%) ⬇️
integration-tests-branch 75.60% <75.00%> (-0.23%) ⬇️
unit-tests 100.00% <100.00%> (ø)
unit-tests-branch 100.00% <100.00%> (ø)
Files with missing lines Coverage Δ
uds/database/__init__.py 100.00% <100.00%> (ø)
uds/database/abstract_database.py 100.00% <100.00%> (ø)
uds/database/data_record/__init__.py 100.00% <100.00%> (ø)
uds/database/data_record/abstract_data_record.py 100.00% <100.00%> (ø)
uds/database/service/__init__.py 100.00% <ø> (ø)
uds/database/service/abstract_service.py 100.00% <100.00%> (ø)

@mdabrowski1990 mdabrowski1990 changed the title API for Databases [Draft] API for Databases Nov 20, 2024
@mdabrowski1990
Copy link
Owner Author

It must be merged after #297

@mdabrowski1990 mdabrowski1990 changed the title [Draft] API for Databases API for Databases Dec 8, 2024
n135c10r
n135c10r previously approved these changes Dec 13, 2024
Copy link
Owner Author

@mdabrowski1990 mdabrowski1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdabrowski1990 mdabrowski1990 merged commit a2ee482 into main Dec 16, 2024
61 checks passed
@mdabrowski1990 mdabrowski1990 deleted the database-api branch December 16, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementation Changes to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messages database API
2 participants