Fix all warnings

.github/workflows/main.yml

@@ -7,13 +7,13 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
-      with:
-        submodules: true
+      - uses: actions/checkout@v2
+        with:
+          submodules: true
 
-    - name: configure
-      run: mkdir build && cd build && cmake ..
-    - name: build
-      run: cmake --build build
-    - name: test
-      run: cd build && ctest
+      - name: configure
+        run: mkdir build && cd build && cmake ..
+      - name: build
+        run: cmake --build build
+      - name: test
+        run: cd build && ctest

.vscode/settings.json

@@ -68,7 +68,12 @@
         "locale": "cpp",
         "mutex": "cpp",
         "ratio": "cpp",
-        "variant": "cpp"
+        "variant": "cpp",
+        "any": "cpp",
+        "charconv": "cpp",
+        "condition_variable": "cpp",
+        "csignal": "cpp",
+        "span": "cpp"
     },
     "editor.tabSize": 2
 }

CMakeLists.txt

@@ -3,7 +3,8 @@ cmake_minimum_required(VERSION 3.13)
 project(CrackingCoding)
 list(APPEND CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/cmake)
 
-set(CMAKE_CXX_STANDARD 11)
+set(CMAKE_CXX_STANDARD 14)
+set(CMAKE_COMPILE_WARNING_AS_ERROR ON)
 
 enable_testing()
 

src/04_trees_and_graphs/first_common_ancestor.cpp

@@ -3,6 +3,8 @@
 // in a data structure. NOTE: This is not necessarily a binary search tree.
 // Hints: # 10, #16, #28, #36, #46, #70, #80, #96
 
+#include <cmath>
+
 #include "utils/tree.h"
 
 using namespace utils;