Consider clearTimeout if mouseEnter parent and take submenu hover events also into consideration #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clearTimeout if parent element is hovered clearTimeout if dropdown-menu is hovered, setTimeout again if dropdown-menu hovered out
clearTimeout if parent element is hovered clearTimeout if dropdown-menu is hovered, setTimeout again if dropdown-menu hovered out
|
This full-on reverses some changes I specifically did to fix a specific change. What really needs to happen with this project is some tests. But I have zero experience with the kind of tests it would need. So, what exactly is the issue here, and how/why does it solve it? I don't quite understand what you're describing in your comment. |
|
Lets explain with a simple flowchart:
|
added 2 commits
August 4, 2014 10:14
…vide a shorter timeout on initial opening dropdowns - added delay-switch timeout (data-delay-switch as data-attribute) to provide a short timeout on switching menu items, when dropdowns are already open - better submenu and nested submenu handling
|
Hey there, i made some small timeout improvements, for opening dropdowns and switching between open submenus. Did my flowchart help you understanding my thoughts? |
added 2 commits
August 4, 2014 11:42
|
|
Closing for inactivity and failure to address my concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured out, that the timeout was not cleared correctly, if other parent element is entered by mouse.
dropdown-menus should also be taken into hover consideration, otherwise dropdown will be closed, if we switch from one dropdown to another and timeout did not finish before.