2.3.1 - Responsive UI refinement #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces responsive UI refinements to improve the application's adaptability across different screen sizes. The changes focus on making the table display more flexible, improving the header layout responsiveness, and adding dynamic text truncation for long content.
Key changes:
- Added responsive width management for the scan form with viewport-based sizing and min/max constraints
- Implemented dynamic text truncation with the
no-wrapclass and JavaScript-based width adjustment for table cells - Restructured the main header layout to use flex-wrap for better mobile responsiveness
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lanscape/ui/templates/scan/ip-table.html | Added CSS classes to table headers for targeted styling in responsive layouts |
| lanscape/ui/templates/scan/ip-table-row.html | Applied no-wrap class to hostname and manufacturer fields for text truncation, changed manufacturer element structure |
| lanscape/ui/templates/scan/config.html | Added ID to label for potential JavaScript targeting |
| lanscape/ui/templates/main.html | Restructured header layout by removing extra div wrapper and changing flex-nowrap to flex-wrap for responsive behavior |
| lanscape/ui/static/js/quietReload.js | Added call to adjustNoWrap function after page reload to maintain text truncation |
| lanscape/ui/static/js/core.js | Implemented adjustNoWrap function to dynamically adjust width of truncated text elements, called on page load and window resize |
| lanscape/ui/static/css/style.css | Added responsive styling including viewport-based widths, text truncation styles, and updated button sizing with percentage-based padding |
| lanscape/core/net_tools.py | Added direct manufacturer field assignment during metadata retrieval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces responsive UI refinements to improve the application's adaptability across different screen sizes. The changes focus on making the table display more flexible, improving the header layout responsiveness, and adding dynamic text truncation for long content.
Key changes:
no-wrapclass and JavaScript-based width adjustment for table cells