Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error with navigator (fixes #131) #142

Closed
wants to merge 1 commit into from
Closed

Fix error with navigator (fixes #131) #142

wants to merge 1 commit into from

Conversation

jonanderdev
Copy link

@jonanderdev jonanderdev commented Jan 23, 2019

Added a check for if we're on the server side, to avoid accessing (in the server side) things like navigator or window which may break the app when the app has server side rendering (like next.js, react-static, ...)

Fixes #131

@jonanderdev jonanderdev changed the title Fix for #131 (error with Server-side-rendered apps due to use of navigator on server side) Fix error with navigator (bug: #131) Jan 23, 2019
@jonanderdev jonanderdev changed the title Fix error with navigator (bug: #131) Fix error with navigator (fixes #131) Jan 23, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

navigator is not defined
1 participant