Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error with navigator (fixes #131) #142

Closed
wants to merge 1 commit into from
Closed

Fix error with navigator (fixes #131) #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/DefaultPlayer/DefaultPlayer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ DefaultPlayer.propTypes = {
video: PropTypes.object.isRequired
};


// Check if we're on the server side.
// This is because otherwise accessing things like navigator or window may break the app when the app has server side rendering.
const isServerSide = () => !(typeof window !== 'undefined' && window !== null);

const connectedPlayer = videoConnect(
DefaultPlayer,
({ networkState, readyState, error, ...restState }) => ({
Expand All @@ -132,7 +137,7 @@ const connectedPlayer = videoConnect(
// TODO: This is not pretty. Doing device detection to remove
// spinner on iOS devices for a quick and dirty win. We should see if
// we can use the same readyState check safely across all browsers.
loading: readyState < (/iPad|iPhone|iPod/.test(navigator.userAgent) ? 1 : 4),
loading: readyState < (!isServerSide() && /iPad|iPhone|iPod/.test(navigator.userAgent) ? 1 : 4),
percentagePlayed: getPercentagePlayed(restState),
percentageBuffered: getPercentageBuffered(restState),
...restState
Expand Down