Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added next-auth for login #1

Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open

Added next-auth for login #1

wants to merge 56 commits into from

Conversation

mdkamran25
Copy link
Owner

No description provided.

assets/toatlGame.png Outdated Show resolved Hide resolved
assets/draw.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using SVGs over PNG format whenever possible. SVGs can be scaled without losing the quality of the image.

Read more about it here: https://cloudinary.com/guides/image-formats/svg-vs-png-4-key-differences-and-how-to-choose#1-image-quality-and-scaling

models/userModels.ts Outdated Show resolved Hide resolved
models/userModels.ts Outdated Show resolved Hide resolved
src/app/(verify)/signup/loading.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leverage react-hook-form with custom hooks(if needed) to DRY-up things

Comment on lines 4 to 15
export default function Input({
handleChange,
value,
labelText,
labelFor,
id,
name,
type,
isRequired = false,
placeholder,
customClass,
}: Partial<InputProps>) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest reconsidering the usage and consumption of this component and based on that, can we please come up with a more tightly-coupled and fail-safe component?

src/components/header/header.tsx Outdated Show resolved Hide resolved
src/types/types.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest reconsidering the composition of this component. Can we please come up with a more tightly-coupled and fail-safe component?

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tic-tac-toe-next-js-ts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 11:57am

…rved keywords in next-auth, hence have to change "user" model name to "userModel"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants