-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data for cross-document view transitions features #22638
Add data for cross-document view transitions features #22638
Conversation
I know this is a stretch, and don't want to derail you from your work here but if, by any chance, you know the bug URLs for implementing cross-document view transitions in Firefox and in Safari, it would be awesome to add them as |
I don't, I'm afraid ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why the collector says unsupported for the viewTransition properties.
https://mdn-bcd-collector.gooborg.com/tests/api/PageRevealEvent
https://mdn-bcd-collector.gooborg.com/tests/api/PageSwapEvent
I bet you've written some code that uses the property and saw it working, though?
LGTM otherwise, just one tag that was added accidentally.
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Ah yes, some of the features are still hidden behind the "viewTransition API for navigations" Chrome flag; the versions I've added in are the ones they'll be enabled for in those cases. Sorry, forgot to mention that. |
okay, in this case I think we need to mark them behind a flag for now. |
@Elchi3 OK, done |
Looks good to me for PageSwapEvent but what about:
These show up unsupported in Chrome 124 for me in https://mdn-bcd-collector.gooborg.com/tests/api/PageRevealEvent |
Flag information added to these too. I've definitely tested them as working with the flag enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Chris!
If these interfaces are behind a flag, I'm skeptical about the availability of pageswap_event and pagereveal_event on Window but I think we should land this PR for now and correct the data if needed later on (hopefully we will soon have a version number for unflagged support and then the flags will disappear anyways).
Note: I'm always happy to review early BCD entries for flagged features, but as you can see, work is required to sort things out properly. So, if it is not absolutely pressing, I would wait until things are shipping properly and only then submit BCD (or have it submitted by the collector).
Yup, this is what I was hoping for; also, it will be a little while until we get the docs reviewed anyway, and by then I'm hoping it will be out from behind the flag.
Yeah, I totally understand the reasoning here. Usually I am a bit further behind the curve than this, but I do get a few work items that are high priority and therefore they want me to get done earlier. |
Summary
Chrome 123/124 includes features required for developers to create cross-document View Transitions. This includes:
PageRevealEvent
interfacepagereveal
eventPageSwapEvent
interfacepageswap
eventNavigationActivation
interface@view-transition
at rule<link rel="expect">
This PR adds/updates the BCD for all of these.
Related ChromeStatus entries:
Test results and supporting details
Related issues