FF65 Reporting API updates #24112
Merged
FF65 Reporting API updates #24112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
hamishwillee
commented
Aug 12, 2024
| "name": "dom.reporting.enabled", | ||
| "value_to_set": "true" | ||
| } | ||
| ] | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "ie": { |
There was a problem hiding this comment.
Further down is a toJSON method. The spec IDL includes this in DeprecationReportBody and the parent class ReportBody base class too. But this method is NOT declared in FF in DeprecationReportBody - would it still be updated here because it is inherited?
There was a problem hiding this comment.
If Firefox doesn't support it, then keeping it set to false seems correct to me.
hamishwillee
commented
Aug 12, 2024
hamishwillee
commented
Aug 12, 2024
hamishwillee
commented
Aug 12, 2024
hamishwillee
commented
Aug 12, 2024
hamishwillee
commented
Aug 12, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates FF features for the Reporting API
Most of this was implemented in FF65 in the "legacy v0 API" in https://bugzilla.mozilla.org/show_bug.cgi?id=1492036 behind pref. Where supported,
to_JSONand worker support added in https://bugzilla.mozilla.org/show_bug.cgi?id=1630947Note, FF does not support:
There's a new header being added in #24047, so this is "backfilling"
Related docs work tracked in mdn/content#35279