Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firefox 132 support for JSON.parse with source features #24617

Merged

Conversation

chrisdavidmills
Copy link
Collaborator

@chrisdavidmills chrisdavidmills commented Oct 3, 2024

Summary

Firefox 132 enables the JSON.parse() with source proposal by default, which specifically includes the following features:

This PR adds Firefox 132 support for the above features, and sets their experimental properties to false.

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1913085 for the release bug.

Test results and supporting details

I've tested these features in Firefox 132 using the test cases available in #22766 and #22800.

Related issues

Main project issue: mdn/content#36113

@github-actions github-actions bot added the data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Oct 3, 2024
@caugner caugner changed the title Add Firefox 132 support for JSON.parse wth source features Add Firefox 132 support for JSON.parse with source features Oct 3, 2024
@hamishwillee
Copy link
Collaborator

FYI @chrisdavidmills , usually @Elchi3 generates a complete BCD for a whole release for shipped things in the first week of the release. What this means is that you only have to do a BCD, should you wish, for the things that are in nightly in the release. Of course we still have to review the PR he creates, and it does not appear to exist yet.

@Elchi3 Note https://mdn-bcd-collector.gooborg.com/tests/javascript/builtins/JSON does not seem to cover this feature?

@hamishwillee hamishwillee merged commit 22fbfaa into mdn:main Oct 3, 2024
5 checks passed
@chrisdavidmills
Copy link
Collaborator Author

FYI @chrisdavidmills , usually @Elchi3 generates a complete BCD for a whole release for shipped things in the first week of the release. What this means is that you only have to do a BCD, should you wish, for the things that are in nightly in the release. Of course we still have to review the PR he creates, and it does not appear to exist yet.

Ah, ok, same as for new Chrome betas. Thanks for letting me @hamishwillee! This is my first time doing a Fx release for quite some time ;-)

@hamishwillee
Copy link
Collaborator

NO worries @chrisdavidmills . I often do them anyway because sometimes Florian is a bit later. YOu just have to be aware the time might be wasted "in the end" if you don't get review by BCD fast enough.

@chrisdavidmills chrisdavidmills deleted the json-parse-with-source-fx132 branch October 4, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants