Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1943050 new webExtension.api.userScripts #25913

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Feb 13, 2025

Summary

Changes for Bug 1943050 Enable userScripts API by default including:

  • runtime.onUserScriptMessage and runtime.onUserScriptConnect
  • userScripts API
  • userScripts permission

Related issues

Related documentation changes in mdn/content#38073

@rebloor rebloor added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Feb 13, 2025
@rebloor rebloor requested review from dotproto and Rob--W February 13, 2025 16:52
@rebloor rebloor self-assigned this Feb 13, 2025
@github-actions github-actions bot added the size:l [PR only] 101-1000 LoC changed label Feb 13, 2025
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several entries are lacking mdn_url. Was that intentional?

"edge": "mirror",
"firefox": {
"version_added": "136",
"notes": "Available for use with Manifest V3 only."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Chrome, these two events are always available in the runtime namespace. In Firefox, the event requires the "userScripts" permission to be granted.

},
"ExecutionWorld": {
"__compat": {
"support": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"support": {
"mdn_url": "https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/API/userScripts/ExecutionWorld",
"support": {

Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Feb 19, 2025
@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Feb 19, 2025
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set Firefox for Android compatibility to unsupported for now.

The feature may be enabled by default soon, once https://bugzilla.mozilla.org/show_bug.cgi?id=1931556 is fixed.

@rebloor rebloor requested a review from Rob--W February 20, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions size:l [PR only] 101-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants