Skip to content

Chrome 119-121 had partial relative oklab()/oklch() support #26551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2025

Conversation

marcustyphoon
Copy link
Contributor

@marcustyphoon marcustyphoon commented Apr 19, 2025

Summary

As noted in the linked issue, this mostly copies the partial support notes for relative rgb(), hsl(), and hwb() in certain Chrome versions to document a very similar incorrect channel serialization range in relative oklab()/oklch().

Test results and supporting details

Code used and per-browser-version results are commented in the linked issue: #26041 (comment). I observed the erroneous behavior in Chromium 121, but not 122.

I'm not familiar enough with the Chromium bug tracker to find if there's a bug that should be linked here. (I wouldn't be surprised if it was fixed with the relative rgb() bug, which links to https://crbug.com/41490327.) Found using bisect-builds.py; will update link.

Related issues

Resolves #26041.

@github-actions github-actions bot added data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:m [PR only] 25-100 LoC changed labels Apr 19, 2025
@marcustyphoon
Copy link
Contributor Author

Chromium bisect tool says:

You are probably looking for a change made after 1223701 (known bad), but no later than 1223771 (first known good).
CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/36293863bf9bbc8131797eb8f4d2bafe8af3de79..96dc037087048acab5971a542fd432fae6b19855

@caugner caugner changed the title Chrome 121 has partial relative oklab()/oklch() support Chrome 119-121 had partial relative oklab()/oklch() support Apr 22, 2025
@marcustyphoon
Copy link
Contributor Author

Ah, shoot, that explains the weird discrepancy in initial versions. Hold on.

@marcustyphoon marcustyphoon requested a review from caugner April 22, 2025 17:25
Copy link
Contributor

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

@caugner caugner merged commit 8342432 into mdn:main Apr 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

css.types.color.oklch - Relative color bug (partial support) until Chromium 121
2 participants