Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace outdated reference to <geometry-box> in mask-clip #31433

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Replace outdated reference to <geometry-box> in mask-clip #31433

merged 1 commit into from
Dec 31, 2023

Conversation

FormularSumo
Copy link
Contributor

@FormularSumo FormularSumo commented Dec 31, 2023 •
edited
Loading

Since w3c/fxtf-drafts#439 and the related pull request were closed, mask-clip uses <coord-box> instead of <geometry-box>. This was mostly fixed in #28157 but I forgot to update this comment as well.

@FormularSumo
Replace outdated reference to <geometry-box> in mask-clip
070f649 
Since w3c/fxtf-drafts#439 and the related pull request were closed, mask-clip uses <coord-box> instead of <geometry-box>. This was mostly fixed in this mdn#28157 previous pull request but I forgot to update this comment as well.
@FormularSumo FormularSumo requested a review from a team as a code owner December 31, 2023 15:30
@FormularSumo FormularSumo requested review from chrisdavidmills and removed request for a team December 31, 2023 15:30
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Dec 31, 2023
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

teoli2003
teoli2003 approved these changes Dec 31, 2023
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit d8f805d into mdn:main Dec 31, 2023
6 checks passed
@FormularSumo FormularSumo deleted the patch-1 branch December 31, 2023 16:17
dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
@FormularSumo @dipikabh
Replace outdated reference to <geometry-box> in mask-clip (mdn#31433)
2bcce67 
Since w3c/fxtf-drafts#439 and the related pull request were closed, mask-clip uses <coord-box> instead of <geometry-box>. This was mostly fixed in this mdn#28157 previous pull request but I forgot to update this comment as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@chrisdavidmills chrisdavidmills Awaiting requested review from chrisdavidmills chrisdavidmills is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FormularSumo @teoli2003