Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Editorial review, Relative color syntax #32004

Merged
merged 66 commits into from
Mar 19, 2024
Merged

feat: Editorial review, Relative color syntax #32004

merged 66 commits into from
Mar 19, 2024

Conversation

chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented Jan 30, 2024 •
edited by estelle
Loading

Description

#30967 contains the engineering technical review for my Relative color syntax content, which has been completed and approved. Thank you to @argyleink @mysteryDate @romainmenke @estelle for your very helpful review work.

This is a new PR based on the same branch, which is intended to contain the editorial review for the same work.

Background information

Chrome 119 and Safari 16.4 add relative color syntax for CSS <color> types, albeit with some bugs/syntax differences.

This PR adds docs to cover this new feature.

See my research document for more details of what this work entails.

Motivation

Additional details

Related issues and pull requests

Estelle's review and approval notes

chrisdavidmills and others added 30 commits December 12, 2023 17:16
@chrisdavidmills
Add docs for relative CSS colors
3a71eb5
@chrisdavidmills
more updates to usage tutorial
ee9c535
@chrisdavidmills
Finish relative colors guide
6f7ccb4
@chrisdavidmills
Add relative mentions to landing pages, modify hsl() page
0c483a0
@chrisdavidmills
Merge branch 'main' into relative-color-syntax
41974b1
@chrisdavidmills
Updates according to estelle comments and as a result of cross-browse…
c53eaf4 
…r testing
@chrisdavidmills
Merge branch 'main' into relative-color-syntax
5ca34b6
@chrisdavidmills @github-actions
Update files/en-us/web/css/color_value/hsl/index.md
bad0899 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@chrisdavidmills
Merge branch 'main' into relative-color-syntax
bfd352c
@chrisdavidmills
fix linting error
e965194
@chrisdavidmills
Fix up existing articles according to latest feedback and implementat…
72e759b 
…ions
@chrisdavidmills @romainmenke
Update files/en-us/web/css/css_colors/relative_colors/index.md
5bd8892 
Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com>
@chrisdavidmills
Merge branch 'main' into relative-color-syntax
f640bd0
@chrisdavidmills
Minor fixes, plus adding details of origin channel resolution values
80d352a
@chrisdavidmills
Get examples working in Safari and Chrome, add details of alpha chann…
dfc849d 
…el defaults
@chrisdavidmills
Merge branch 'main' into relative-color-syntax
d819015
@chrisdavidmills
Update rgb() page with relative syntax info
838ad84
@chrisdavidmills
Merge branch 'relative-color-syntax' of github.com:chrisdavidmills/co…
9354868 
…ntent into relative-color-syntax
@chrisdavidmills
Merge branch 'main' into relative-color-syntax
9d623fc
@chrisdavidmills
Adding hwb() relative syntax explanation, plus some small tweaks
2654bc9
@chrisdavidmills
Adding lab() relative colors explanation
df9a4c9
@chrisdavidmills
Adding oklab() relative syntax explanation
ada10ec
@chrisdavidmills
Adding lch() and oklch() relative syntax explanation
6ac9320
@chrisdavidmills
Add color() relative syntax explanation
2f5e718
@chrisdavidmills
Making heading levels correct and consistent
a9b436e
@chrisdavidmills
Various bits of cleanup
9c61786
@chrisdavidmills
Merge branch 'main' into relative-color-syntax
85c062b
@chrisdavidmills
Fix flaws
9a42f52
@chrisdavidmills
Merge branch 'relative-color-syntax' of github.com:chrisdavidmills/co…
eaf2a72 
…ntent into relative-color-syntax
@chrisdavidmills @argyleink
Update files/en-us/web/css/color_value/hsl/index.md
9060623 
Co-authored-by: Adam Argyle <argyle@google.com>
@estelle
Copy link
Member

estelle commented Mar 13, 2024

Fixes #32408

@estelle estelle linked an issue Mar 13, 2024 that may be closed by this pull request
[css-color] Percent reference ranges do not imply maximum allowed values in color functions #32408
Closed
estelle

This comment was marked as resolved.

Sign in to view

estelle

This comment was marked as resolved.

Sign in to view

@estelle estelle mentioned this pull request Mar 15, 2024
Open
estelle

This comment was marked as resolved.

Sign in to view

estelle

This comment was marked as resolved.

Sign in to view

estelle

This comment was marked as resolved.

Sign in to view

@estelle estelle mentioned this pull request Mar 18, 2024
Open
6 tasks
estelle
estelle reviewed Mar 19, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RGB and HSL approved.

found an issue with an existing RGB example, so created a separate PR

files/en-us/web/css/color_value/hsl/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/hsl/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/hsl/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/rgb/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/rgb/index.md Show resolved Hide resolved
estelle
estelle approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squeeeeeee!

just some minor suggestions and a minor fix

files/en-us/web/css/color_value/oklab/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/oklab/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/oklab/index.md Show resolved Hide resolved
files/en-us/web/css/color_value/oklch/index.md Show resolved Hide resolved
files/en-us/web/css/color_value/oklch/index.md Show resolved Hide resolved
files/en-us/web/css/color_value/oklch/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/oklch/index.md Show resolved Hide resolved
files/en-us/web/css/color_value/oklch/index.md Show resolved Hide resolved
files/en-us/web/css/color_value/oklab/index.md Show resolved Hide resolved
@chrisdavidmills chrisdavidmills merged commit d55f3aa into mdn:main Mar 19, 2024
9 checks passed
@chrisdavidmills chrisdavidmills deleted the relative-color-syntax branch March 19, 2024 11:05
@estelle estelle mentioned this pull request Mar 19, 2024
Closed
@romainmenke
Copy link
Contributor

@chrisdavidmills @estelle Thank you for all your work on this subject 🎉

@chrisdavidmills
Copy link
Contributor Author

@chrisdavidmills @estelle Thank you for all your work on this subject 🎉

And thank you for all your useful input, @romainmenke!

@estelle estelle mentioned this pull request Mar 28, 2024
Closed
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainmenke romainmenke romainmenke left review comments

@OnkarRuikar OnkarRuikar OnkarRuikar left review comments

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/xl [PR only] >1000 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[css-color] Percent reference ranges do not imply maximum allowed values in color functions
4 participants
@chrisdavidmills @romainmenke @estelle @OnkarRuikar