Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 5 update (From Django 4) #32406

Merged
merged 8 commits into from
Feb 28, 2024
Merged

Django 5 update (From Django 4) #32406

merged 8 commits into from
Feb 28, 2024

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Feb 23, 2024

This updates the Django tutorial from v4 to v5. It also does some useful stuff like showing how to validate that there can only be one genre with a particular name, case insensitive.

Related demo PRs in mdn/django-locallibrary-tutorial#137 and mdn/django-diy-blog#21

We also need #32336 in

Fixes #31569

@github-actions github-actions bot added Content:Learn:Django Learning area Django docs size/xs [PR only] 0-5 LoC changed labels Feb 23, 2024
Copy link
Contributor

github-actions bot commented Feb 23, 2024

Preview URLs (14 pages)
External URLs (80)

URL: /en-US/docs/Learn/Server-side/Django/development_environment
Title: Setting up a Django development environment


URL: /en-US/docs/Learn/Server-side/Django/web_application_security
Title: Django web application security


URL: /en-US/docs/Learn/Server-side/Django/Models
Title: Django Tutorial Part 3: Using models


URL: /en-US/docs/Learn/Server-side/Django/Sessions
Title: Django Tutorial Part 7: Sessions framework


URL: /en-US/docs/Learn/Server-side/Django/skeleton_website
Title: Django Tutorial Part 2: Creating a skeleton website


URL: /en-US/docs/Learn/Server-side/Django/Generic_views
Title: Django Tutorial Part 6: Generic list and detail views


URL: /en-US/docs/Learn/Server-side/Django/Forms
Title: Django Tutorial Part 9: Working with forms


URL: /en-US/docs/Learn/Server-side/Django/Deployment
Title: Django Tutorial Part 11: Deploying Django to production


URL: /en-US/docs/Learn/Server-side/Django/Admin_site
Title: Django Tutorial Part 4: Django admin site


URL: /en-US/docs/Learn/Server-side/Django/django_assessment_blog
Title: Assessment: DIY Django mini blog


URL: /en-US/docs/Learn/Server-side/Django/Testing
Title: Django Tutorial Part 10: Testing a Django web application


URL: /en-US/docs/Learn/Server-side/Django/Authentication
Title: Django Tutorial Part 8: User authentication and permissions


URL: /en-US/docs/Learn/Server-side/Django/Home_page
Title: Django Tutorial Part 5: Creating our home page

(comment last updated: 2024-02-27 00:57:10)

@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Feb 23, 2024
@github-actions github-actions bot added size/l [PR only] 501-1000 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Feb 26, 2024
Comment on lines +432 to +437
<li>
<form id="logout-form" method="post" action="{% url 'admin:logout' %}">
{% csrf_token %}
<button type="submit" class="btn btn-link">Logout</button>
</form>
</li>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this section most relevant one - you can't GET your logout, so you need to POST and also style that form to look like a link (or at least we choose to do that)

@hamishwillee hamishwillee marked this pull request as ready for review February 27, 2024 00:56
@hamishwillee hamishwillee requested a review from a team as a code owner February 27, 2024 00:56
@hamishwillee hamishwillee requested review from teoli2003 and removed request for a team February 27, 2024 00:56
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit f7f7cca into main Feb 28, 2024
10 checks passed
@teoli2003 teoli2003 deleted the update_django_5_0 branch February 28, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn:Django Learning area Django docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Django built in authentication system no longer accepts GET method for requests against logout url
2 participants