Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSSPageRule.style update to CSSPageDescriptors #34960

Merged
merged 5 commits into from
Aug 2, 2024
Merged

CSSPageRule.style update to CSSPageDescriptors #34960

merged 5 commits into from
Aug 2, 2024

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Jul 22, 2024 •
edited
Loading

FF129 Adds support for CSSPageRule.style being a CSSPageDescriptors rather than a CSSStyleDeclaration.

This adds docs.

Related work can be tracked in #34702

@hamishwillee hamishwillee requested review from a team as code owners July 22, 2024 04:05
@hamishwillee hamishwillee requested review from sideshowbarker and pepelsbey and removed request for a team July 22, 2024 04:05
@hamishwillee hamishwillee marked this pull request as draft July 22, 2024 04:05
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Jul 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 22, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-07-31 09:55:42)

@hamishwillee hamishwillee mentioned this pull request Jul 22, 2024
Closed
8 tasks
@sideshowbarker sideshowbarker removed their request for review July 22, 2024 04:40
@hamishwillee hamishwillee marked this pull request as ready for review July 22, 2024 07:32
@hamishwillee hamishwillee requested a review from bsmth July 22, 2024 07:35
@bsmth
Copy link
Member

bsmth commented Jul 23, 2024

Thanks Hamish, a couple of comments for you to consider, but I think we're ready to go when you take a look at the feedback. I like the examples 👍🏻

@hamishwillee hamishwillee requested a review from bsmth July 26, 2024 04:13
@hamishwillee
Copy link
Collaborator Author

@bsmth Thanks for the review. I like the examples too. In general the live examples are much better than just having code because you know the code works. I've accepted your changes, and only open question is whether we can safely have properties side-by-side with our linter.

Back to you.

bsmth
bsmth approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, LGTM! Thank you, Hamish!

@hamishwillee hamishwillee merged commit 474a7c0 into mdn:main Aug 2, 2024
9 checks passed
@OnkarRuikar OnkarRuikar mentioned this pull request Aug 3, 2024
Merged
@hamishwillee hamishwillee deleted the ff129csspageddescriptors branch August 3, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@bsmth bsmth bsmth approved these changes

@pepelsbey pepelsbey Awaiting requested review from pepelsbey pepelsbey is a code owner automatically assigned from mdn/core-yari-content

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishwillee @bsmth