Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid GFM alert syntax, new markdownlint rule #35344

Merged
merged 6 commits into from
Aug 10, 2024
Merged

Fix invalid GFM alert syntax, new markdownlint rule #35344

merged 6 commits into from
Aug 10, 2024

Conversation

Josh-Cena
Copy link
Member

I added a new Markdownlint rule that's able to catch the following:

  • > [NOTE]
  • > ![NOTE]
  • > [!Note]

@Josh-Cena Josh-Cena requested review from a team as code owners August 7, 2024 00:24
@Josh-Cena Josh-Cena requested review from hamishwillee and removed request for a team August 7, 2024 00:24
@github-actions github-actions bot added Content:SVG SVG docs system [PR only] Infrastructure and configuration for the project size/s [PR only] 6-50 LoC changed labels Aug 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

Preview URLs (7 pages)

(comment last updated: 2024-08-10 06:13:46)

@Josh-Cena Josh-Cena mentioned this pull request Aug 7, 2024
Closed
PassionPenguin
PassionPenguin reviewed Aug 7, 2024
View reviewed changes
.markdownlint.jsonc Outdated Show resolved Hide resolved
@Josh-Cena @PassionPenguin
Update .markdownlint.jsonc
4149d9d 
Co-authored-by: Hoarfroster <hoarfroster@outlook.com>
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Aug 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Aug 7, 2024
@Josh-Cena Josh-Cena mentioned this pull request Aug 7, 2024
Merged
estelle
estelle approved these changes Aug 10, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@Josh-Cena Josh-Cena requested a review from a team as a code owner August 10, 2024 06:12
@Josh-Cena Josh-Cena requested review from chrisdavidmills and removed request for a team August 10, 2024 06:12
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Aug 10, 2024
@Josh-Cena Josh-Cena merged commit 29a5380 into mdn:main Aug 10, 2024
9 checks passed
@Josh-Cena Josh-Cena deleted the fix-alert branch August 10, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PassionPenguin PassionPenguin PassionPenguin left review comments

@estelle estelle estelle approved these changes

@hamishwillee hamishwillee Awaiting requested review from hamishwillee hamishwillee is a code owner automatically assigned from mdn/yari-content-mdn

@chrisdavidmills chrisdavidmills Awaiting requested review from chrisdavidmills chrisdavidmills is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/s [PR only] 6-50 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Josh-Cena @estelle @PassionPenguin