Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix globals, part 12: reportError() #35927

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Fix globals, part 12: reportError() #35927

merged 5 commits into from
Sep 26, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Sep 18, 2024 •
edited
Loading

Description

Motivation

Additional details

Related issues and pull requests

part of the #33019

for firefox release note update, see https://bugzilla.mozilla.org/show_bug.cgi?id=1722448, #8608, mdn/browser-compat-data#12531 and #9314

/cc @wbamberg

@github-actions github-actions bot added Content:WebAPI Web API docs Content:Firefox Content in the Mozilla/Firefox subtree size/m [PR only] 51-500 LoC changed labels Sep 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 18, 2024 •
edited
Loading

Preview URLs (11 pages)
Flaws (1)

Note! 10 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/WebRTC_API/Signaling_and_video_calling
Title: Signaling and video calling
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/RTCPeerConnection/removetrack_event does not exist
External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/93
Title: Firefox 93 for developers

(comment last updated: 2024-09-26 23:22:56)

@skyclouds2001 skyclouds2001 marked this pull request as ready for review September 18, 2024 07:00
@skyclouds2001 skyclouds2001 requested review from a team as code owners September 18, 2024 07:00
@skyclouds2001 skyclouds2001 requested review from pepelsbey and sideshowbarker and removed request for a team September 18, 2024 07:00
@sideshowbarker sideshowbarker removed their request for review September 18, 2024 08:26
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

wbamberg
wbamberg approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice to see you back @skyclouds2001 !

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Sep 26, 2024
@wbamberg wbamberg merged commit 63297de into mdn:main Sep 26, 2024
9 checks passed
@skyclouds2001 skyclouds2001 deleted the reportError branch September 27, 2024 13:51
OnkarRuikar pushed a commit to OnkarRuikar/content that referenced this pull request Sep 28, 2024
@skyclouds2001 @wbamberg @OnkarRuikar
Fix globals, part 12: reportError() (mdn#35927)
b9bf9d4 
* move

* update

* Update index.md

* Update index.md

---------

Co-authored-by: wbamberg <will@bootbonnet.ca>
fiji-flo pushed a commit that referenced this pull request Oct 2, 2024
@skyclouds2001 @wbamberg @fiji-flo
Fix globals, part 12: reportError() (#35927)
ead0767 
* move

* update

* Update index.md

* Update index.md

---------

Co-authored-by: wbamberg <will@bootbonnet.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@pepelsbey pepelsbey Awaiting requested review from pepelsbey pepelsbey is a code owner automatically assigned from mdn/core-yari-content

Assignees
No one assigned
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @wbamberg