Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial review: add interpolate-size and calc-size() #35934

Merged
merged 8 commits into from
Oct 11, 2024

Conversation

chrisdavidmills
Copy link
Contributor

Description

Chrome 129 supports the interpolate-size property and calc-size() function, which enable animation to/from and calculations involving intrinsic size values. This PR adds reference documentation for these new features.

See also:

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested a review from a team as a code owner September 18, 2024 12:15
@chrisdavidmills chrisdavidmills requested review from estelle and removed request for a team September 18, 2024 12:15
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Sep 18, 2024
@chrisdavidmills chrisdavidmills marked this pull request as draft September 18, 2024 12:16
Copy link
Contributor

github-actions bot commented Sep 18, 2024

Preview URLs (9 pages)
Flaws (1)

Note! 8 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/calc
Title: calc()
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/auto redirects to /en-US/docs/Web/CSS/width
External URLs (3)

URL: /en-US/docs/Web/CSS/calc-size
Title: calc-size()


URL: /en-US/docs/Web/CSS/interpolate-size
Title: interpolate-size

(comment last updated: 2024-10-11 09:13:36)

@github-actions github-actions bot added size/l [PR only] 501-1000 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Sep 19, 2024
@github-actions github-actions bot added the Content:Glossary Glossary entries label Sep 19, 2024
@chrisdavidmills chrisdavidmills marked this pull request as ready for review September 19, 2024 20:03
@chrisdavidmills chrisdavidmills requested a review from a team as a code owner September 19, 2024 20:03
@chrisdavidmills chrisdavidmills requested review from Elchi3 and removed request for a team September 19, 2024 20:03
@chrisdavidmills chrisdavidmills changed the title Add interpolate-size and calc-size() Technical review: add interpolate-size and calc-size() Sep 19, 2024
files/en-us/web/css/calc-size/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/calc-size/index.md Show resolved Hide resolved
files/en-us/web/css/interpolate-size/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/calc-size/index.md Show resolved Hide resolved
@chrisdavidmills chrisdavidmills changed the title Technical review: add interpolate-size and calc-size() Editorial review: add interpolate-size and calc-size() Sep 24, 2024
@chrisdavidmills
Copy link
Contributor Author

Thanks for the technical review, @bramus!

Over to you for the editorial review, @estelle.

@estelle estelle self-assigned this Oct 7, 2024
files/en-us/glossary/intrinsic_size/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/block-size/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/calc/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_transitions/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/height/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/interpolate-size/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/interpolate-size/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/interpolate-size/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/interpolate-size/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/interpolate-size/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Oct 8, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Oct 9, 2024
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One clarification question and one nit. Approving to not hold this up through the weekend.

files/en-us/web/css/calc-size/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/calc-size/index.md Outdated Show resolved Hide resolved
@chrisdavidmills chrisdavidmills merged commit c0daf1f into mdn:main Oct 11, 2024
8 checks passed
@chrisdavidmills chrisdavidmills deleted the calc-interpolate-size branch October 11, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries size/l [PR only] 501-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants