Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global api page type #36041

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Remove global api page type #36041

merged 2 commits into from
Oct 7, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Sep 25, 2024

Description

Motivation

Additional details

Related issues and pull requests

Can closes #33019
Depends on all PRs in #33019 got merged
See also #35498

/cc @wbamberg

@github-actions github-actions bot added Content:Meta Content in the meta docs system [PR only] Infrastructure and configuration for the project size/xs [PR only] 0-5 LoC changed labels Sep 25, 2024
Copy link
Contributor

github-actions bot commented Sep 25, 2024

Preview URLs

(comment last updated: 2024-10-06 10:55:03)

@skyclouds2001 skyclouds2001 marked this pull request as ready for review October 6, 2024 10:53
@skyclouds2001 skyclouds2001 requested review from a team as code owners October 6, 2024 10:53
@skyclouds2001 skyclouds2001 requested review from chrisdavidmills and removed request for a team October 6, 2024 10:53
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 great work @skyclouds2001 !

@wbamberg wbamberg merged commit 80bd981 into mdn:main Oct 7, 2024
9 checks passed
@skyclouds2001 skyclouds2001 deleted the remove-global branch October 7, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Meta Content in the meta docs size/xs [PR only] 0-5 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove globals from Web/API
2 participants