Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(manifest): Improvements to background_color page #36085

Merged
merged 3 commits into from
Oct 2, 2024
Merged

docs(manifest): Improvements to background_color page #36085

merged 3 commits into from
Oct 2, 2024

Conversation

dipikabh
Copy link
Contributor

@dipikabh dipikabh commented Sep 28, 2024 •
edited
Loading

Description

This PR is part of improving the web/manifest docs:

  • Adds "Syntax", "Values", "Description", and "See also" sections
  • Mentions support for prefers-color-scheme
  • Adds prose and some more code to the example

While improving background_color, I revisited theme_color page (previously updated in #35643) and made some similar adjustments for consistency.

Motivation

To ensure all sections have sufficient explanation, all caveats from spec are covered, and the manifest pages follow a similar template

Additional details

Spec link: https://w3c.github.io/manifest/#background_color-member

Related issues and pull requests

Tracking issue: mdn/mdn#560

@dipikabh dipikabh requested a review from a team as a code owner September 28, 2024 04:57
@dipikabh dipikabh requested review from Elchi3 and removed request for a team September 28, 2024 04:57
@github-actions github-actions bot added Content:Manifest size/m [PR only] 51-500 LoC changed labels Sep 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 28, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-10-02 17:58:52)

@dipikabh dipikabh mentioned this pull request Sep 28, 2024
Open
bsmth
bsmth approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Dipika. Didn't spot anything unusual, so a +1 from me!

@dipikabh
Copy link
Contributor Author

dipikabh commented Oct 2, 2024

Thanks for reviewing, Brian!

@dipikabh dipikabh merged commit 4d01b5f into mdn:main Oct 2, 2024
8 checks passed
@dipikabh dipikabh deleted the manifest-color branch October 2, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3 Elchi3 is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:Manifest size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dipikabh @bsmth