Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Missing Reference for -webkit-fill-available #36190

Merged
merged 6 commits into from
Oct 8, 2024

Conversation

ragul1697
Copy link
Contributor

Description

Fixes #35618 - Added CSS Reference entry for -webkit-fill-available

@ragul1697 ragul1697 requested a review from a team as a code owner October 4, 2024 13:20
@ragul1697 ragul1697 requested review from chrisdavidmills and removed request for a team October 4, 2024 13:20
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed labels Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Preview URLs

Flaws (48)

URL: /en-US/docs/Web/CSS/WebKit_Extensions
Title: -webkit-prefixed CSS extensions
Flaw count: 48

  • macros:
    • /en-US/docs/Web/CSS/-webkit-app-region does not exist
    • /en-US/docs/Web/CSS/-webkit-border-horizontal-spacing does not exist
    • /en-US/docs/Web/CSS/-webkit-border-vertical-spacing does not exist
    • /en-US/docs/Web/CSS/-webkit-column-axis does not exist
    • /en-US/docs/Web/CSS/-webkit-column-progression does not exist
    • and 43 more flaws omitted

(comment last updated: 2024-10-08 08:50:03)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ragul1697! I had never heard of this before, so I found researching it interesting. Thanks for adding it.

I do have an issue with your content update — -webkit-fill-available is a value, not a property, so it doesn't fit in the list you have inserted it into.

Maybe you could add a "Values" section at the bottom of the page, add an entry below it for -webkit-fill-available, and explain that it is a proprietary value for sizing properties such as width and height, which causes a container to take up all the available space in that dimension. What do you think?

You could perhaps also explain that really this is a non-standard way of doing what Flexbox's stretch value achieves, and you should use that instead to fix such problems? Or am I misunderstanding this?

@Josh-Cena
Copy link
Member

It is not a property. I think you need to make a new section called "-webkit-prefixed property values" and explain which property it is for and what standard replacement exists. You should also not use cssxref because there's no page for it and there won't be one.

@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Oct 6, 2024
@ragul1697
Copy link
Contributor Author

Hi @chrisdavidmills, I have made changes for the -webkit-fill-available CSS Value. Please have a look at it. Thanks😎

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nearly there now, nice work @ragul1697! I just had an edit suggestion and a question for you.

files/en-us/web/css/webkit_extensions/index.md Outdated Show resolved Hide resolved
@ragul1697
Copy link
Contributor Author

Hi @chrisdavidmills, I have added the suggested content. Thanks😎

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you @ragul1697! Merging.

@chrisdavidmills chrisdavidmills merged commit 39520e7 into mdn:main Oct 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing doc: -webkit-fill-available
3 participants