Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification.silent: Add Firefox 132 rel note, and improve documentation #36191

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Notification.silent: Add Firefox 132 rel note, and improve documentation #36191

merged 2 commits into from
Oct 9, 2024

Conversation

chrisdavidmills
Copy link
Contributor

Description

Firefox 132 supports the Notification.silent property.

This PR:

  • Adds an entry for it to the Fx132 rel notes.
  • Cleans up some of the descriptive text.
  • Adds a slightly better example (the existing snippet was a bit useless as it didn't handle the permissions request necessary to be able to fire a system notification).

See the shipping bug at https://bugzilla.mozilla.org/show_bug.cgi?id=1809028

Motivation

Additional details

Related issues and pull requests

Docs issue: #36119

@chrisdavidmills chrisdavidmills requested review from a team as code owners October 4, 2024 13:51
@chrisdavidmills chrisdavidmills requested review from pepelsbey and wbamberg and removed request for a team October 4, 2024 13:51
@github-actions github-actions bot added Content:WebAPI Web API docs Content:Firefox Content in the Mozilla/Firefox subtree labels Oct 4, 2024
@chrisdavidmills chrisdavidmills changed the title Add Firefox 132 rel note, and improve silent documentation Notification.silent: Add Firefox 132 rel note, and improve silent documentation Oct 4, 2024
@github-actions github-actions bot added the size/s [PR only] 6-50 LoC changed label Oct 4, 2024
@chrisdavidmills chrisdavidmills changed the title Notification.silent: Add Firefox 132 rel note, and improve silent documentation Notification.silent: Add Firefox 132 rel note, and improve documentation Oct 4, 2024
@chrisdavidmills chrisdavidmills mentioned this pull request Oct 4, 2024
Open
8 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024 •
edited
Loading

Preview URLs

External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/132
Title: Firefox 132 for developers

(comment last updated: 2024-10-04 14:55:04)

pepelsbey
pepelsbey approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks :)

@pepelsbey pepelsbey merged commit 79f5e2c into mdn:main Oct 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena left review comments

@pepelsbey pepelsbey pepelsbey approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisdavidmills @pepelsbey @Josh-Cena