Improvement to customElements.whenDefined() javascript example

[sidewayss]

The current example doesn't filter the list and creates more Promises than it needs to. new Set() seems like the best way to filter down to unique names.

btw - I noticed that Prettier broke my 80 character line const tags..., but not my 76 character line const promises.... Is the limit 79? I have a soft, personal limit of 80, partly as a tribute to the old Teletype printers. Is that the reason for the Prettier limit here? If so, 80 would be a better limit than 79 :-)

EDIT - now I see that it's the trailing comma added by Prettier that pushes it to 81 chars wide. I'm still not used to those trailing commas. My ESLint doesn't like them either...

[github-actions]

Preview URLs

• /en-US/docs/Web/API/CustomElementRegistry/whenDefined

(comment last updated: 2024-10-06 16:17:20)

[Josh-Cena]

LGTM, and yes Prettier is hard to tame. Luckily it doesn't depend on how you originally wrote your code at all, so you can rest assured that there's little you can do to make it print differently unless you change variable names.