Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New pages: HTML<form>FormAction #36272

Merged
merged 5 commits into from
Oct 9, 2024
Merged

New pages: HTML<form>FormAction #36272

merged 5 commits into from
Oct 9, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Oct 8, 2024

part of #35544

@estelle estelle requested a review from a team as a code owner October 8, 2024 22:07
@estelle estelle requested review from wbamberg and removed request for a team October 8, 2024 22:07
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited
Loading

Preview URLs

Flaws (8)

URL: /en-US/docs/Web/API/HTMLInputElement/formAction
Title: HTMLInputElement: formAction property
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/formEnctype does not exist
    • /en-US/docs/Web/API/HTMLInputElement/formMethod does not exist
    • /en-US/docs/Web/API/HTMLInputElement/formNoValidate does not exist
    • /en-US/docs/Web/API/HTMLInputElement/formTarget does not exist

URL: /en-US/docs/Web/API/HTMLButtonElement/formAction
Title: HTMLButtonElement: formAction property
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/HTMLButtonElement/formEnctype does not exist
    • /en-US/docs/Web/API/HTMLButtonElement/formMethod does not exist
    • /en-US/docs/Web/API/HTMLButtonElement/formNoValidate does not exist
    • /en-US/docs/Web/API/HTMLButtonElement/formTarget does not exist

(comment last updated: 2024-10-09 15:27:40)

@estelle @wbamberg
Apply suggestions from code review
b2968b0 
Co-authored-by: wbamberg <will@bootbonnet.ca>
wbamberg
wbamberg approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks Estelle!

@estelle
Copy link
Member Author

estelle commented Oct 9, 2024

👍 thanks Estelle!

thanks for doing that additional edit!

@estelle estelle merged commit 1c31c8e into main Oct 9, 2024
9 checks passed
@estelle estelle deleted the formaction branch October 9, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @wbamberg