Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): make color contrast colorblind friendly #36299

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix(css): make color contrast colorblind friendly #36299

merged 2 commits into from
Oct 11, 2024

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Oct 11, 2024 •
edited
Loading

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner October 11, 2024 02:09
@OnkarRuikar OnkarRuikar requested review from estelle and removed request for a team October 11, 2024 02:09
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Oct 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-10-11 20:28:18)

estelle
estelle reviewed Oct 11, 2024
View reviewed changes
files/en-us/web/css/_doublecolon_after/index.md Outdated
@@ -51,12 +51,14 @@ Let's create two classes: one for boring paragraphs and one for exciting ones. W
```css
.exciting-text::after {
content: " <- EXCITING!";
color: green;
color: lime;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color contrast is only 1.37, so we need to go with something with more contrast. we can stick with green since the other is purple; green versus red is an issue in protanopia and deuteranopia... so you can use either color, but you can't constrast them.

@estelle estelle merged commit 313a326 into mdn:main Oct 11, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the patch-3 branch October 12, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of different color scheme in examples
2 participants
@OnkarRuikar @estelle