Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): add snappport glossary section #36300

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(css): add snappport glossary section #36300

wants to merge 1 commit into from
+50 −15

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar requested review from a team as code owners October 11, 2024 03:49
@OnkarRuikar OnkarRuikar requested review from estelle and hamishwillee and removed request for a team October 11, 2024 03:49
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries size/s [PR only] 6-50 LoC changed labels Oct 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

Preview URLs (15 pages)

(comment last updated: 2024-10-12 03:58:25)

estelle
estelle reviewed Oct 11, 2024
View reviewed changes
files/en-us/glossary/scroll_container/index.md Outdated
@@ -15,3 +15,15 @@ A scroll container includes a scrollport and scroll bars.
## Scrollport

The scrollport is the visible part of a scroll container and coincides with the padding box of the scroll container. The scroll bars are used to move content in and out of the scrollport so that the content can be viewed.

## Scroll snap container
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The origianl page is about scroll container, more as it relates to overflow. I think this content would be better if we created a page for scroll snapping, since we never really define what snapping is anywhere i don't think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a new glossary page for CSS scroll snap.

@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee Awaiting requested review from hamishwillee hamishwillee is a code owner automatically assigned from mdn/yari-content-mdn

@estelle estelle Awaiting requested review from estelle

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:Glossary Glossary entries size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Snapport" is used but not defined
2 participants
@OnkarRuikar @estelle