fix: CSS zoom should be a not animatable property #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct. |
github-actions
bot
added
the
idle
pepelsbey
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Good catch! Thank you :)
Browsers are all over the place with the zoom animation, but the data should be aligned with the spec.
I filed a bug for Firefox, let’s see how it goes.
|
Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the animatable type of CSS zoom to be not-animatable.
Motivation
According to the WD of the CSS zoom property, the animation type of the zoom property is not animatable.
Some browsers, such as Firefox, which recently started supporting zoom, treat it as animatable though.
Here is a capture of the WD page.
Additional details
Related issues and pull requests