Update syntax in bookController to match lesson#245
Merged
hamishwillee merged 1 commit intomdn:mainfrom Nov 26, 2023
Merged
Conversation
|
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct. |
Collaborator
|
Looks good. I plan to test this on Monday or Tuesday. |
Collaborator
|
Thanks. Looks good by inspection and also by testing. |
|
Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced syntax in the bookController file to to remove inconsistency and to match the syntax used in the tutorial.
Motivation
There were three different implementations of the same logic in the tutorial and project files. It was confusing for readers, since elsewhere in the tutorial the syntax is consistent when code is repeated.
Additional details
Related issues and pull requests
Relates to Issue #30443 mdn/content/issues/30443
Relates to PR #30476 mdn/content/pull/30476