Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): add star.gif #25

Merged
merged 3 commits into from
Aug 26, 2024
Merged

fix(css): add star.gif #25

merged 3 commits into from
Aug 26, 2024

Conversation

OnkarRuikar
Copy link
Contributor

I've used existing images from the shared-assets in the PR. The star.gif would be an excellent addition to reusable images for the demos.

Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we use this opportunity to replace the ancient GIF format with a bit more suitable PNG? It also a bit smaller :) 253 bytes vs 396 bytes 🧐

star

@OnkarRuikar
Copy link
Contributor Author

How about we use this opportunity to replace the ancient GIF format with a bit more suitable PNG? It also a bit smaller :) 253 bytes vs 396 bytes 🧐

What size would you prefer? We can have multiple sizes for multiple scenarios.

@pepelsbey
Copy link
Member

What size would you prefer? We can have multiple sizes for multiple scenarios.

8px based sizes are usually pretty common: 16, 24, 32. Something like that :)

@OnkarRuikar
Copy link
Contributor Author

OnkarRuikar commented Aug 26, 2024

8px based sizes are usually pretty common: 16, 24, 32. Something like that :)

Created 16x16, 32x32, and 256x256 sized normal and inverted versions.

Also added some more images from the content repo that have been duplicated 3-4 times. We will update content later.

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carrying this one over since Vadim is on PTO. Looks like review comments addressed, everything else looks good to me. Thank you!

@bsmth bsmth merged commit 29232d7 into mdn:main Aug 26, 2024
@OnkarRuikar OnkarRuikar deleted the css_star branch August 27, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants