Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/AvailableInWorkers): add zh-CN translations #11894

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

skyclouds2001
Copy link
Contributor

Summary

relates to mdn/content#36060 and #11888

/cc @yin1999 @JasonLamv-t @jasonren0403

Problem

Solution


Screenshots

observe the test result

Before

None

After

image


How did you test this change?

manntually see browser preview

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Oct 1, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review October 1, 2024 18:01
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner October 1, 2024 18:01
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the space

kumascript/macros/AvailableInWorkers.ejs Outdated Show resolved Hide resolved
Co-authored-by: A1lo <yin199909@aliyun.com>
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @skyclouds2001

Copy link
Member

@JasonLamv-t JasonLamv-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@caugner caugner merged commit b10b2ae into mdn:main Oct 2, 2024
13 checks passed
@skyclouds2001 skyclouds2001 deleted the availableinworker branch October 2, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants