-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom pointsets for dvgeo #299
base: main
Are you sure you want to change the base?
Conversation
… groups. derivatives not added yet
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
- Coverage 41.02% 40.90% -0.13%
==========================================
Files 13 13
Lines 4119 4166 +47
==========================================
+ Hits 1690 1704 +14
- Misses 2429 2462 +33 ☔ View full report in Codecov by Sentry. |
adflow/pyADflow.py
Outdated
@@ -4523,6 +4595,7 @@ def computeJacobianVectorProductFwd( | |||
# For the geometric xDvDot perturbation we accumulate into the | |||
# already existing (and possibly nonzero) xsdot and xvdot | |||
if xDvDot is not None or xSDot is not None: | |||
# TODO fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs fixing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it looks like I forgot to make the necessary changes for this to work. Tagging this PR as draft until I can get to it.
Leaving this as a draft PR because after #330 is merged, I want to push a small update to this PR that brings similar ptset changes to the changes that come from that other PR. |
Purpose
This PR adds the capability to specify custom pointsets based on family names that are tracked separately in DVGeo. Each pointset can receive its own custom kwargs. See the relevant PR in baseclasses for how the custom families are specified: mdolab/baseclasses#89
This is a somewhat complete implementation but there are several assumptions. First, the custom families should not overlap. The implication here comes up with derivative computations; if families overlap, the surface seeds of the overlapped nodes will be double counted.
Second, we assume the custom families span the selected design family, although this is not a hard requirement. We may want to add a check if the provided families actually do span the entire design family.
Expected time until merged
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable