adding validation to setStages

[FwazB]

Added Validation helper functions to define Date, then implemented logic to make sure the startDate is after the endDate. Finally implemented the logic into the setStages function

[channing-magiceden]

Is this able to catch 2024-06-31 issue?

[FwazB]

https://stackoverflow.com/questions/1214234/javascript-date-parsing-bug-fails-for-dates-in-june

Should be good based on this article, defining and using that will fix

[channing-magiceden]

Seems `new Date()` will not fail

[tenthirtyone]

@FwazB I have suffered immensely from JS dates. It's a "whack a mole" problem. There's always another gotcha.

I am seeing seconds (from block.timestamp) used and date strings like @channing-magiceden is calling out. Something like this could be helpful, modify as necessary:

function isValidDate(date: string) {
  if (/^\d+$/.test(date)) {
    // Date expects milliseconds, * 1000 here if using seconds
    const milliSeconds = parseInt(date, 10);

    return isValidDateInMilliSeconds(milliSeconds);
  } else {
    return isValidDateString(date);
  }
}

function isValidDateInMilliSeconds(milliseconds: number) {
  return !isNaN(new Date(milliseconds).getDate());
}

function isValidDateString(dateString: string) {
  const [year, month, day] = dateString.split(/[-/]/).map(Number);
  const date = new Date(year, month - 1, day);

  if (
    !(
      date.getFullYear() === year &&
      date.getMonth() + 1 === month &&
      date.getDate() === day
    )
  ) {
    return false;
  } else {
    return !isNaN(date.getTime());
  }
}

But this has some things to be aware of as well:

isValidDate("20240631") === truebecause the regex will treat this as milliseconds.

But in general, with js dates you can split/compare the input against the date values to ensure they match.