magicdrop v1.0.1

[wolfy-nft]

ERC721CM v1.0.1

• add setTransferable function to block transfers
• add baseURI and tokenURISuffix to the setup function
• add setup lock, can only be called once

ERC721M v1.0.1

• add setTransferable function to block transfers
• add baseURI and tokenURISuffix to the setup function
• add setup lock, can only be called once

ERC1155M v1.0.1

• add setup lock, can only be called once

CLI

• update cli to set baseURI and tokenURISuffix on setup
• update cli to freeze/thaw contracts
• update cli to check if contract was already setup
• updated default transfer list to 1 (ME transfer list)

[wolfy-nft]

this can be ignored, its a direct copy of ERC721A with an initializer

[wolfy-nft]

pre-approves our seaport conduit for immediate trading

[wolfy-nft]

this can be ignored, its a direct copy of ERC721AQueryable that extends ERC721ACloneable

[tenthirtyone]

1. I think the architecture is backwards for the factory/registry. If it were building a car:

The factory that makes the car can be upgraded
The catalog that lists car models can be upgraded
But the actual cars can never be upgraded or fixed

Once an NFT contract is deployed, it's stuck with whatever implementation it was cloned from. You can't upgrade it.

2. The entire MagicDropTokenImplRegistry can be replaced with a simple mapping

3. The initialize/setup is cargo-cult programming (pattern implemented without understanding it). Because the Upgrade pattern is backwards, initialization is not doing what it is supposed to do -> Setting the proxy contract state. So a setup function is hacked in to do what initialize would normally do.

I believe the factory/registry could be replaced by:

The factory/registry could be replaced by:

contract SimpleFactory Ownable {
    uint256 fee;
    mapping(uint256 => address) public implementations;

    constructor(){...}
    
    function deploy(
        uint256 implId,  // An ID that maps to deployed token standards
        string calldata name,
        string calldata symbol,
        address initialOwner
    ) external payable returns (address) {
        require(msg.value >= fee, “Fee too low.”);

        address impl = implementations[implId];
        require(impl != address(0), "Invalid impl");
        
        address instance = LibClone.clone(impl);
        IERC1155M(instance).initialize(name, symbol, initialOwner);
        return instance;
    }

	… setters for fee and implementations
}

NOW, this would make upgrading for ZKSync a 1 line change to the ZKProxy.sol contract I provided in Slack.