fix: Mealplanner Date Off By One (Daylight Savings)

[michael-genson]

What type of PR is this?

(REQUIRED)

• bug

What this PR does / why we need it:

(REQUIRED)

As mentioned in Discord, the mealplanner has two November 5ths (easily reproducible on any instance):

I realized that November 5th is when daylight savings time ends, every developer's favorite time of year. Peeking at the code, I noticed there were two entries for November 5th: one at 0:00, and one at 23:00.

This fix tweaks the date calculation to increment by a day (using JS magic), rather than 24 * 60 * 60 * 1000 ms:

return Array.from(Array(numDays).keys()).map(
  (i) => {
    const date = new Date(weekRange.value.start.getTime());
    date.setDate(date.getDate() + i);
    return date;
  }
);

Which issue(s) this PR fixes:

(REQUIRED)

N/A, Discord

Testing

(fill-in or delete this section)

Locally. I checked some other red flag dates too just to make sure (e.g. next year's daylight savings).

[boc-the-git]

Looks good